Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tree-sitter-sql #9634

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Bump tree-sitter-sql #9634

merged 7 commits into from
Feb 24, 2024

Conversation

ds-cbo
Copy link
Contributor

@ds-cbo ds-cbo commented Feb 15, 2024

Fixes #9550

ds-cbo
ds-cbo commented Feb 15, 2024
View reviewed changes
runtime/queries/sql/highlights.scm
value: (cast
name: (keyword_cast) @function.builtin
parameter: [(literal)]?))
parameter: [(literal)]?)))
Copy link
Contributor Author

@ds-cbo ds-cbo Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these parentheses have any function, but I copied them from upstream to have as little difference as possible, to make diff updates easier

(same for the extra leading space a few lines down)

the-mikedavis
the-mikedavis reviewed Feb 15, 2024
View reviewed changes
languages.toml Outdated Show resolved Hide resolved
the-mikedavis
the-mikedavis approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kirawi kirawi added A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer. labels Feb 17, 2024
@archseer archseer merged commit ec9efde into helix-editor:master Feb 24, 2024
6 checks passed
uek-1 pushed a commit to uek-1/helix that referenced this pull request Feb 24, 2024
@ds-cbo @uek-1
Bump tree-sitter-sql (helix-editor#9634)
ba41f52
@ds-cbo ds-cbo deleted the bump-tree-sitter-sql branch February 26, 2024 09:59
ofzo pushed a commit to ofzo/helix-editor that referenced this pull request Feb 26, 2024
@ds-cbo @ofzo
Bump tree-sitter-sql (helix-editor#9634)
7f825a2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@ds-cbo @postsolar
Bump tree-sitter-sql (helix-editor#9634)
65e9564
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@ds-cbo @mtoohey31
Bump tree-sitter-sql (helix-editor#9634)
5428527
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@ds-cbo @Vulpesx
Bump tree-sitter-sql (helix-editor#9634)
646269e
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@ds-cbo
Bump tree-sitter-sql (helix-editor#9634)
5e4f6d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when rendering certain SQL files
4 participants
@ds-cbo @archseer @the-mikedavis @kirawi